summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Remove defunct code from read() and recite()Rory Dudley2024-03-242-27/+0
| | | | | Remove some commented out code, that is no longer needed after the parser overhaul.
* Documentation for incant_Rory Dudley2024-03-241-0/+1
| | | | Add docstring for `incant_quiet_io`.
* Remove debug lineRory Dudley2024-03-241-2/+0
| | | | Remove println!() in main that was used for debugging the parser output.
* Fix tests for githubRory Dudley2024-03-231-2/+2
| | | | | Fix the ~ test, so that it uses env!("HOME"), instead of my hard-coded home directory.
* read() and recite() overhaulRory Dudley2024-03-2314-1195/+1438
| | | | | | | | | | | | | | | | | | | | | | | | | Rebuilt the LR parser (i.e. read()) from the ground up. This required that some changes be made to recite(), in order to accomodate the new data structures. These data structures were each split out into their own file, in order to make working with each component a bit easier. In addition to reworking the parts of the parser already present, some new features were also added, such as: - Support for strings (' and ") - Support for environment variables ($) - Support for interpreting tild as $HOME (~) - Support for sub-reading and sub-reciting (`) Notes: This is a huge commit that changes almost the entire program (main.rs is still the same, except for imports). Ideally, huge sweeping changes like this should not occur on the codebase, but since this is still pre-alpha, I guess this is acceptable. This is far from the end of patch set, however, as there is quite a lot of cleanup that needs to be done. For instance, checking for internal poems and environment variables should get split out to their own functions/macros. There is also some defunct code (that's commented out), that is unlikely to be useful in the future.
* Poem::read macrosRory Dudley2024-03-052-234/+189
| | | | | | | | | | | | | | Added the following macros: push!: Creates a Verse from a stanza, taking into account some extra options (such as the Meter). push1!: Creates a Verse from a stanza, but also allows looking ahead by a single character, in order to pattern match certain meters (i.e. And ('&&') and Addendum ('>>')). Replaced the code in the huge, redundant match statements in Poem::read with the macros described above.
* Fix macro_export formattingRory Dudley2024-03-051-2/+2
| | | | | Fixed formatting of macro_export in src/recite/ps.rs to be more consistent.
* Add unit tests for the new IO metersRory Dudley2024-03-031-0/+74
| | | | | | | Added six new units tests related to the IO meters (Read, Write, and Addendum). The first three tests check the meters under normal operation , and the last three tests ensures that the parser throws an error, unless one or more files where specified for the operation.
* Clear the buffer for STDIN after incant_write/incant_addendumRory Dudley2024-03-021-0/+6
| | | | | Clear the 'out' buffer after we have written STDOUT to the files specified after the Meter::Write or Meter::Addendum verse.
* Cleanup commentsRory Dudley2024-03-021-24/+0
| | | | | | | Remove commented code relating to error checks for the incant_io functions. The parser should detect if no files where specified for Meter::Read, Meter::Write, or Meter::Addendum, meaning that these checks are not necessary.
* Add file redirection capabilitiesRory Dudley2024-03-021-14/+337
| | | | | | | | | | | Added the following file redirection capabilies: - '<': Read input into STDIN - '>': Write STDOUT to file - '>>': Append STDOUT to file If no files are specified, this counts as a parser error, and so no code will be executed, even when used in combination with the string (';') meter. Currently, there is no way to redirect STDERR.
* Fix handling of SIGINTRory Dudley2024-02-293-6/+53
| | | | | | | | | | | | | | | Keep track of a new atomic variable: at_prompt, which is set to true just before blocking on io::stdin.read_line, and set to false just calling Poem::read. Additionally, for background tasks, there is a new ps macro called btask, which changes the process group of commands that are forked into the background, so that they don't receive SIGINT from the keyboard. Notes: Changing the process group on the Command is done via CommandExt. More details here: https://doc.rust-lang.org/std/os/unix/process/trait.CommandExt.html#tymethod.process_group
* Change runner typeghaRory Dudley2024-02-291-3/+3
| | | | The 'debian-latest' isn't a real runner, so change to 'ubuntu-latest'.
* Github actionsRory Dudley2024-02-291-0/+59
| | | | | Add a yaml file to run `cargo check`, `cargo fmt`, and `cargo test`, every time a branch is pushed, or every time a pull request is made.
* Parser testspipesRory Dudley2024-02-291-0/+157
| | | | Added twelve different tests for the parser (Poem::read).
* Parsing poems from a fileRory Dudley2024-02-291-0/+22
| | | | | | Added a match statement in the main parser loop that pushes a new verse into the poem if a newline is found. This might happen if parsing a poem from a file.
* Fix ps macros doc commentsRory Dudley2024-02-281-5/+5
| | | | | [Verse] is not in scope for the ps module, so removed the link in the documentation comments.
* Add doc comments for ps macrosRory Dudley2024-02-281-0/+19
| | | | | Added documentation comments for the recite::ps::task and recite::ps::ctask macros.
* Add doc comments for incant_ functionsRory Dudley2024-02-281-0/+43
| | | | | Added documentation comments for the Meter::incant_ functions, describing how each function operates.
* Parser comments and error checkingRory Dudley2024-02-281-9/+22
| | | | | | | | | Added an index to keep track of what position each char is at in the loop. Added a more verbose error message, which prints out the column that the parse error was detected, as well as the glyph that threw the error. Added more comments to the '&', whitespace, and char match statements. Changed parser behavior, so that a ';' glyph without a stanza does not cause a parser error.
* Refactor status variables in Poem::read()Rory Dudley2024-02-281-28/+29
| | | | | | | Moved the 'couplet' and 'metered' variables into functions impl'd for Verse. This cuts down on the boilerplate in the parsing loop, and also makes it so that their match statements are only ran when needed, rather than being called at every iteration of the loop.
* Fix && behavior regressionrmerrRory Dudley2024-02-281-9/+9
| | | | | | Introduce a switch to break from recite() if the forked process returns a non-zero exit code. The one except to this, is when using semicolons, then we do not care if the previous command failed.
* Remove zombie slayer code from main replRory Dudley2024-02-281-10/+0
| | | | | Reaping is currently handled by a signal handler, so this code is no longer necessary.
* Remove custom errors and fix background forkingRory Dudley2024-02-276-140/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes the custom errors in src/recite/erro.rs, and replaces them with std::io::Errors throughout (recite(), incant_, macros). Fixed a bug with the way forking to the background is handled, where registering the signal handler in main for all processes would break couplets (i.e. pipes). Instead, this sets up a new signal handler each time a process is forked into the background. It uses a Vec<i32> to keep track of all the background processes. Notes: First off, there is some defunct code in the main repl loop, which is an example of killing zombie processes after each prompt. This should be removed, but I kept it in, just in case I go back to it for some reason. To be honest, I have no clue why this code works. In theory, I should have to remove the pid from the pids: Vec<i32> if waitpid returns a positive integer. However, when I tried this, it completely broke the program. ¯\_(ツ)_/¯ Also, it's worth noting that registering a signal handler with signal_hook::low_level::register, is somewhat costly, according to their docs. Given that this only occurs for background processes that are forked, however, I think it is acceptable. Finally, we never unregister the signal handler, so I'm not sure if that's still hanging out in memory somewhere or no.
* Cleanup recite(), custom errors, fixed forkingRory Dudley2024-02-266-115/+231
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First off, moved the giant match statements out of recite(), and into macros in src/recite/ps.rs. There still needs to be two, since any verse using the 'couplet' meter will need to redirect its STDOUT. Now the recite() function returns a Result<(), Mishap>, which can be invoked when calling the incant_ functions. Custom errors were added in the form of 'Mishap''s. They are intended to be returned from the incant_ functions, in the event that something goes wrong with the Command::spawn() or Child::wait(). They each take a String, which should be the verb or stanza that was entered by the user. The incant_ functions separate the functionality of each type of meter from the recite() function. They return a Result<i32, Mishap>, where i32 is the exit code of the program that ran, and Mishap is a possible error. Before, the shell was cheating at forking a process to the background. It would actually spawn a thread to wait for that process to finish. Now, the program simply registers a handler for SIGCHLD, and uses libc's waitpid() function to reap the child process, and print some output to the user, indicating that it's finished. Notes: This was a huge patch which did some desperately needed cleanup of the recite() function. Moving forward, will need to add more documentation, and will probably scrap the custom errors, since this implementation is a little half-baked. It's worth looking into in the future, but we can probably live with io::Error's for the time being. Fixing forking was a pretty big deal, though. In Linux, and other u**x-like operating systems, parent processes need to reap their child processes, otherwise they become zombies. Previously, the dwvsh did this by spawning a separate thread to wait for child processes that were forked to the background. Now, we are registering a handle for SIGCHLD, which is a signal that gets sent to the parent when one of their children finishes, or is killed. Using waitpid(2), we can determine which process ended, and do something about it. In the case of a processes that was forked into the background, when it finished, waitpid(2) will return its PID. For foreground processes, it returns -1.
* Replace ctrlc with signal-hooksignalRory Dudley2024-02-243-99/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced the 'ctrlc' crate with 'signal-hook' for handling of SIGINT. The 'signal_hook::low_level::register' function is actually unsafe. However, according to https://docs.rs/signal-hook/latest/signal_hook/low_level/fn.register.html, it is only unsafe in the case of multithreaded applications. There are some race conditions as well. For instance, it appears that even when we fork to a child process, SIGINT is captured on both that process, as well as the shell. Notes: The replacement was motivated by the fact that 'ctrlc' appears to use a separate thread to handle interrupts. This is evident if you run: ps aux | grep dwvsh USER PID %CPU %MEM VSZ RSS TTY STAT START COMMAND user pid 0.0 0.0 71500 3072 term Sl+ 20:08 target/debug/dwvsh Further reading in 'man ps' under 'PROCESS STATE CODES', reveals that 'l' is a process state referring to multithreaded applications. Given the nature of interupts, this seems unnecessary. The issue where SIGINT is captured by both the shell, and child process will have to be addressed.
* Reorganization and commentsRory Dudley2024-02-223-420/+691
| | | | | | | | | | | | Broke out the structs for a poem into their own file: src/recite.rs. Also put the 'prefresh' function into it's own file: src/recite/path.rs. Commented most of the parser code (including structs and helper methods related to parsing (i.e. Verse, Stanza, Meter, Poem)). Renamed any instance of the 'paths' variable to 'path'. Notes: The biggest task now is to cleanup Poem::recite. It has a ton of bogus error messages, and (seemingly) redundant code.
* Add back the 'cd' commandRory Dudley2024-02-201-0/+17
| | | | Add back change directory functionality into the new parser.
* Parsing improvementsRory Dudley2024-02-201-214/+153
| | | | | | | | | | | | | | Now the parser goes char by char, since special characters like '|' and '&' don't necessarily have to be whitespace seperated. Also added some VERY basic error detection for the parser (revolving around special chars). Notes: Even with the improvements to the parsing, this will likely get scrapped in favor of a cleaner approach. There are a lot of edge cases that are either difficult to handle with the current way things are, or just aren't being handled at all. The current implementation is also wont for better error detection and messages.
* Pipes, forks, and consecutive callsRory Dudley2024-02-201-90/+407
| | | | | | | | | | This adds some preliminary support for pipes (|), forks (&), and consecutive command calls (&&) to the shell. Notes: This branch is a huge WIP, and am only pushing it, cause it's late, and want to have my changes saved. A lot of cleanup and comments will be necessary moving forward.
* Only print command name in error messagesRory Dudley2024-02-191-2/+8
| | | | | Only print out the command name in error messages, rather than printing out the full path to the command.
* Merge pull request #2 from pinecat/evryloopRory D2024-02-191-20/+106
|\ | | | | Path refresh
| * Path refresh refactor, comments, and error messagesevryloopRory Dudley2024-02-191-43/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'eval' function was renamed to 'repl'. The code to refresh the $PATH was moved into it's own function: 'prefresh', and is now being called in three locations: - At the beginning of 'repl', before the main loop - Inside the main loop, possibly during a path search if the command is not initially found - Inside the main loop, if the call to Command::spawn() throws an error, and the error is ErrorKind::NotFound Doc comments were added for each function, as well as a few more comments throughout that detail the program's control flow. The error messages in the main repl loop were cleaned up to have a more consistent style, and to provide more/better detail.
| * Better handling of errors during the forkRory Dudley2024-02-191-3/+12
| | | | | | | | | | | | | | | | | | | | | | Adds two additional error checks when the shell forks: 1. Checks for permission (+r, +x) 2. Checks if the file exists The first error may occur if the user does not have read access to the file, or if the file is not executable. The second error may occur if a file was removed from the $PATH, and the $PATH hasn't been refreshed yet.
| * Refresh path only if command is not foundRory Dudley2024-02-191-19/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a modified implementation of the 'refresh path on every iteration of the loop' idea. It instead, only refreshes the path if the command is not found. After the first refresh, if the command still is not found, it throws and error. Notes: This is probably the most sane solution, however, it has an issue. It can detect new files in the path just fine, but it cannot detect if a file was removed from the path. It may be prudent to expand the error handling when we fork, to see what kind of error the process is returning, and handle it more apropriately. Another solution may be to check the always check the existence of a file in the path before returning it from the match closure. This will overall slow down the REPL, however, since we'd now be making that check twice.
| * Refresh paths every loopRory Dudley2024-02-191-6/+9
|/ | | | | | | | | | | | | Implements the path refresh at the start of each REPL loop. On this commit, it is printing out how long it needed to refresh all the paths in milliseconds. Notes: This may be an easier solution than using inotify. There is the obvious downside of a small delay each time we need to print the loop, but the highest I've seen so far is around 12 milliseconds, which seems acceptable. Using inotify as an alternative, it adds quite a few more dependencies, and some overhead in way of a watcher.
* Call programs from full and relative pathsRory Dudley2024-02-171-9/+15
| | | | | | | | | | Allow user to input a fullpath or relative path to a file that should be forked to. Notes: Currently, this does not check whether or not that file at the path specified is executable or not, but, if it isn't we will throw an 'Unable to fork' error, before printing the next prompt.
* Control flow in cdRory Dudley2024-02-171-2/+2
| | | | | Make the control flow in our cd implementation a bit easier to read/follow.
* EOF behaviorRory Dudley2024-02-171-0/+1
| | | | Print a newline before quitting when we receive an EOF.
* Update cdRory Dudley2024-02-171-4/+1
| | | | | Instead of printing an error if the path is not specified, simply 'cd' into the user's home directory instead.
* Change directoriesRory Dudley2024-02-161-0/+19
| | | | Added logic to change directories with 'cd'.
* Capture SIGINTRory Dudley2024-02-163-0/+121
| | | | | | Added logic to capture the interrupt signal. Using a rust crate called 'ctrlc' to do the heavy lifting. Program will simply reprint the prompt on a new line if the interrup signal is detected.
* Detect EOFRory Dudley2024-02-161-1/+8
| | | | Added logic to detect for an EOF (i.e. <C-d>).
* Initial commitRory Dudley2024-02-164-0/+108
An extremely miniamal shell. It is capable of forking processes, and passing arguments to them, but that's pretty much it. Notes: This is pretty much a prototype, to see how easily something like a shell could be implemented in Rust.