summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Replace ctrlc with signal-hooksignalRory Dudley2024-02-243-99/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced the 'ctrlc' crate with 'signal-hook' for handling of SIGINT. The 'signal_hook::low_level::register' function is actually unsafe. However, according to https://docs.rs/signal-hook/latest/signal_hook/low_level/fn.register.html, it is only unsafe in the case of multithreaded applications. There are some race conditions as well. For instance, it appears that even when we fork to a child process, SIGINT is captured on both that process, as well as the shell. Notes: The replacement was motivated by the fact that 'ctrlc' appears to use a separate thread to handle interrupts. This is evident if you run: ps aux | grep dwvsh USER PID %CPU %MEM VSZ RSS TTY STAT START COMMAND user pid 0.0 0.0 71500 3072 term Sl+ 20:08 target/debug/dwvsh Further reading in 'man ps' under 'PROCESS STATE CODES', reveals that 'l' is a process state referring to multithreaded applications. Given the nature of interupts, this seems unnecessary. The issue where SIGINT is captured by both the shell, and child process will have to be addressed.
* Reorganization and commentsRory Dudley2024-02-223-420/+691
| | | | | | | | | | | | Broke out the structs for a poem into their own file: src/recite.rs. Also put the 'prefresh' function into it's own file: src/recite/path.rs. Commented most of the parser code (including structs and helper methods related to parsing (i.e. Verse, Stanza, Meter, Poem)). Renamed any instance of the 'paths' variable to 'path'. Notes: The biggest task now is to cleanup Poem::recite. It has a ton of bogus error messages, and (seemingly) redundant code.
* Add back the 'cd' commandRory Dudley2024-02-201-0/+17
| | | | Add back change directory functionality into the new parser.
* Parsing improvementsRory Dudley2024-02-201-214/+153
| | | | | | | | | | | | | | Now the parser goes char by char, since special characters like '|' and '&' don't necessarily have to be whitespace seperated. Also added some VERY basic error detection for the parser (revolving around special chars). Notes: Even with the improvements to the parsing, this will likely get scrapped in favor of a cleaner approach. There are a lot of edge cases that are either difficult to handle with the current way things are, or just aren't being handled at all. The current implementation is also wont for better error detection and messages.
* Pipes, forks, and consecutive callsRory Dudley2024-02-201-90/+407
| | | | | | | | | | This adds some preliminary support for pipes (|), forks (&), and consecutive command calls (&&) to the shell. Notes: This branch is a huge WIP, and am only pushing it, cause it's late, and want to have my changes saved. A lot of cleanup and comments will be necessary moving forward.
* Only print command name in error messagesRory Dudley2024-02-191-2/+8
| | | | | Only print out the command name in error messages, rather than printing out the full path to the command.
* Merge pull request #2 from pinecat/evryloopRory D2024-02-191-20/+106
|\ | | | | Path refresh
| * Path refresh refactor, comments, and error messagesevryloopRory Dudley2024-02-191-43/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'eval' function was renamed to 'repl'. The code to refresh the $PATH was moved into it's own function: 'prefresh', and is now being called in three locations: - At the beginning of 'repl', before the main loop - Inside the main loop, possibly during a path search if the command is not initially found - Inside the main loop, if the call to Command::spawn() throws an error, and the error is ErrorKind::NotFound Doc comments were added for each function, as well as a few more comments throughout that detail the program's control flow. The error messages in the main repl loop were cleaned up to have a more consistent style, and to provide more/better detail.
| * Better handling of errors during the forkRory Dudley2024-02-191-3/+12
| | | | | | | | | | | | | | | | | | | | | | Adds two additional error checks when the shell forks: 1. Checks for permission (+r, +x) 2. Checks if the file exists The first error may occur if the user does not have read access to the file, or if the file is not executable. The second error may occur if a file was removed from the $PATH, and the $PATH hasn't been refreshed yet.
| * Refresh path only if command is not foundRory Dudley2024-02-191-19/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a modified implementation of the 'refresh path on every iteration of the loop' idea. It instead, only refreshes the path if the command is not found. After the first refresh, if the command still is not found, it throws and error. Notes: This is probably the most sane solution, however, it has an issue. It can detect new files in the path just fine, but it cannot detect if a file was removed from the path. It may be prudent to expand the error handling when we fork, to see what kind of error the process is returning, and handle it more apropriately. Another solution may be to check the always check the existence of a file in the path before returning it from the match closure. This will overall slow down the REPL, however, since we'd now be making that check twice.
| * Refresh paths every loopRory Dudley2024-02-191-6/+9
|/ | | | | | | | | | | | | Implements the path refresh at the start of each REPL loop. On this commit, it is printing out how long it needed to refresh all the paths in milliseconds. Notes: This may be an easier solution than using inotify. There is the obvious downside of a small delay each time we need to print the loop, but the highest I've seen so far is around 12 milliseconds, which seems acceptable. Using inotify as an alternative, it adds quite a few more dependencies, and some overhead in way of a watcher.
* Call programs from full and relative pathsRory Dudley2024-02-171-9/+15
| | | | | | | | | | Allow user to input a fullpath or relative path to a file that should be forked to. Notes: Currently, this does not check whether or not that file at the path specified is executable or not, but, if it isn't we will throw an 'Unable to fork' error, before printing the next prompt.
* Control flow in cdRory Dudley2024-02-171-2/+2
| | | | | Make the control flow in our cd implementation a bit easier to read/follow.
* EOF behaviorRory Dudley2024-02-171-0/+1
| | | | Print a newline before quitting when we receive an EOF.
* Update cdRory Dudley2024-02-171-4/+1
| | | | | Instead of printing an error if the path is not specified, simply 'cd' into the user's home directory instead.
* Change directoriesRory Dudley2024-02-161-0/+19
| | | | Added logic to change directories with 'cd'.
* Capture SIGINTRory Dudley2024-02-163-0/+121
| | | | | | Added logic to capture the interrupt signal. Using a rust crate called 'ctrlc' to do the heavy lifting. Program will simply reprint the prompt on a new line if the interrup signal is detected.
* Detect EOFRory Dudley2024-02-161-1/+8
| | | | Added logic to detect for an EOF (i.e. <C-d>).
* Initial commitRory Dudley2024-02-164-0/+108
An extremely miniamal shell. It is capable of forking processes, and passing arguments to them, but that's pretty much it. Notes: This is pretty much a prototype, to see how easily something like a shell could be implemented in Rust.