diff options
author | Rory Dudley | 2024-03-28 23:26:02 -0600 |
---|---|---|
committer | Rory Dudley | 2024-03-28 23:26:02 -0600 |
commit | 491d3fbff384d4b04483b54e5bb78d23bb1181c5 (patch) | |
tree | 470b0fc2ab0a476d682e104bdb03275ffd6b8671 /src/poem/recite.rs | |
parent | 14a74aea0f02da53e0f61c572da2c5244ed80551 (diff) | |
download | dwarvish-491d3fbff384d4b04483b54e5bb78d23bb1181c5.tar.gz |
Remove hard-coded PATH
Use $PATH, instead of a hard-coded PATH from main(). This means that
there is no longer a need to pass around PATH to
repl()/recite()/path::refresh(), since path::refresh() can call env::var
directly.
Since the hard-coded paths were removed, there needs to be some way to
define $PATH. When running the debug build, dwvsh will look in
'dist/etc/dwvshrc' for the initial environment setup. For the release
target, dwvsh will look in '/etc/dwvshrc'. After the global rc file is
sourced, dwvsh will try to source ~/.dwvshrc if it exists, so users can
extend their environment without root access (assuming a release install).
Notes
Notes:
Throughout a lot of this program, we're calling `env!("HOME")`, in order
to get the user's home directory. Technically, this is not correct. The
env!() macro resolves environment variables during compile time, while
env::var() gets environment variables for the running process (i.e. the
shell). See https://users.rust-lang.org/t/env-vs-env-var/88119 for more
info. In the near future, this will need to be addressed. Might be worth
looking into what other shells do, though one idea I had was to invoke
'/usr/bin/id', grab the user's ID, and use it to grab the rest of the
info from /etc/passwd. This would be handled in an /etc/dwvlogin or
/etc/dwvprofile most likely.
Diffstat (limited to 'src/poem/recite.rs')
-rw-r--r-- | src/poem/recite.rs | 48 |
1 files changed, 6 insertions, 42 deletions
diff --git a/src/poem/recite.rs b/src/poem/recite.rs index a88007d..f2af591 100644 --- a/src/poem/recite.rs +++ b/src/poem/recite.rs @@ -6,26 +6,15 @@ use crate::poem::elements::rune::Rune; use std::env; use std::{ io, - path::Path, sync::{Arc, Mutex}, }; pub trait Reciteable { - fn recite( - &self, - path: &Vec<&Path>, - bins: &mut Vec<String>, - stdout: Option<bool>, - ) -> Result<String, io::Error>; + fn recite(&self, bins: &mut Vec<String>, stdout: Option<bool>) -> Result<String, io::Error>; } impl Reciteable for Poem { - fn recite( - &self, - path: &Vec<&Path>, - bins: &mut Vec<String>, - stdout: Option<bool>, - ) -> Result<String, io::Error> { + fn recite(&self, bins: &mut Vec<String>, stdout: Option<bool>) -> Result<String, io::Error> { // Should we print to stdout or always capture it let stdout = stdout.unwrap_or(true); @@ -58,7 +47,7 @@ impl Reciteable for Poem { let envar = name[1..].to_string(); let envar = match env::var(envar) { Ok(envar) => envar.to_string(), - Err(_) => "".to_string(), + Err(_) => String::new(), }; *word = word.replace(name.as_str(), envar.as_str()); } @@ -95,7 +84,7 @@ impl Reciteable for Poem { Some(poem) => poem, None => break, // TODO: Return an error }; - let out = poem.recite(path, bins, Some(false))?; + let out = poem.recite(bins, Some(false))?; if out.contains("\n") { let mut out = out.split("\n"); let next = out.next().unwrap_or("").trim(); @@ -129,35 +118,10 @@ impl Reciteable for Poem { None => {} } - // // Check if the user wants to exit the shell - // if verse.verb() == "exit" || verse.verb() == "quit" { - // exit(0); - // } - // - // // Check if the user wants to change directories - // if verse.verb() == "cd" { - // let path = match verse.clause() { - // Some(path) => path[0].to_string(), - // None => env!("HOME").to_string(), - // }; - // - // match std::env::set_current_dir(&path) { - // Ok(_) => continue, - // Err(e) => { - // eprintln!( - // "cd: unable to change into {}: {}", - // path, - // e.to_string().to_lowercase() - // ); - // continue; - // } - // } - // } - // Incant the verse if it's a built-in let index = anthology::lookup(&verse.verb()); let status = if index.is_some() { - anthology::incant(&verse, index.unwrap(), path, bins) + anthology::incant(&verse, index.unwrap(), bins) } else { // Incant the verse, based on its meter // Check if the verb exists @@ -165,7 +129,7 @@ impl Reciteable for Poem { // again // If it still doesn't exist, print an error if !verse.spellcheck(bins) { - *bins = path::refresh(path); + *bins = path::refresh(); if !verse.spellcheck(bins) { eprintln!("dwvsh: {}: command not found", verse.verb()); |