summaryrefslogtreecommitdiffstats
path: root/src/poem/anthology/source.rs
diff options
context:
space:
mode:
authorRory Dudley2024-06-04 16:25:32 -0600
committerRory Dudley2024-06-04 16:25:32 -0600
commitc4cd1e2c165c4f34ebf67fa9350f8732b2aeca13 (patch)
treea8dd06c7563c205eb4710f620cf89d89ae17d98b /src/poem/anthology/source.rs
parentdedadcfd30516c40692fe495a6ad10aea7c050de (diff)
downloaddwarvish-c4cd1e2c165c4f34ebf67fa9350f8732b2aeca13.tar.gz
Updated the way built-in commands are called/used
Previously, built-in commands were fairly primitive, merely outputting STDOUT and STDERR with the print! macros. However, we need them to behave like normal programs, that is: - Acknowledge their verse's meter (forking, piping, etc.), - Ability to capture STDOUT and STDERR (>, 2>), - and Affect the currently running environment. For these reasons, the anthology was reworked, and now contains the Anthology struct, which mimics both std::process::{Child, Command}. The AnthologyStdin helper struct was also created, for built-ins to take input on STDIN, though no built-in is currently using it. Each built-ins' incant functions were updated to return a std::process::Output. It contains output from STDOUT, output from STDERR, and the exit code of the "process". A fix was also implemented for aliases, where the STDOUT and STDERR vectors were not being copied to the newly constructed verse.
Notes
Notes: There is some cleanup that needs to happen on this patch. For one, the spellcheck function is no longer being used, so there is a generic OS error if the program cannot be found in the $PATH. Also, anthology::lookup gets called twice, which shouldn't need to happen.
Diffstat (limited to 'src/poem/anthology/source.rs')
-rw-r--r--src/poem/anthology/source.rs98
1 files changed, 81 insertions, 17 deletions
diff --git a/src/poem/anthology/source.rs b/src/poem/anthology/source.rs
index 3c81110..0ed759c 100644
--- a/src/poem/anthology/source.rs
+++ b/src/poem/anthology/source.rs
@@ -1,7 +1,8 @@
use crate::compose::Environment;
-use crate::poem::Verse;
use crate::poem::{read::Readable, recite::Reciteable, Poem};
use std::fs;
+use std::os::unix::process::ExitStatusExt;
+use std::process::{ExitStatus, Output};
/// source
///
@@ -12,12 +13,29 @@ use std::fs;
/// ```sh
/// source ~/.dwvshrc
/// ```
-pub fn incant(verse: &Verse, out: &mut Vec<u8>, env: &mut Environment) -> i32 {
- let files = match verse.clause() {
+pub fn incant(
+ clause: &Option<Vec<String>>,
+ uout: bool,
+ uerr: bool,
+ env: &mut Environment,
+) -> Output {
+ let mut status = 0;
+ let mut out: Vec<u8> = Vec::new();
+ let mut err: Vec<u8> = Vec::new();
+ let files = match clause {
Some(clause) => clause,
None => {
- eprintln!("source: not enough arguments");
- return 1;
+ status = 1;
+ if uerr {
+ err.append(&mut "source: not enough arguments\n".as_bytes().to_vec());
+ } else {
+ eprintln!("source: not enough arguments");
+ }
+ return Output {
+ status: ExitStatus::from_raw(status),
+ stdout: out,
+ stderr: err,
+ };
}
};
@@ -25,31 +43,77 @@ pub fn incant(verse: &Verse, out: &mut Vec<u8>, env: &mut Environment) -> i32 {
let poetry = match fs::read_to_string(&file) {
Ok(poetry) => poetry,
Err(e) => {
- eprintln!(
- "source: could not load {}: {}",
- file,
- e.to_string().to_lowercase()
- );
- return 127;
+ status = 127;
+ if uerr {
+ err.append(
+ &mut format!(
+ "source: could not load {}: {}\n",
+ file,
+ e.to_string().to_lowercase()
+ )
+ .as_bytes()
+ .to_vec(),
+ );
+ } else {
+ eprintln!(
+ "source: could not load {}: {}",
+ file,
+ e.to_string().to_lowercase()
+ );
+ }
+ return Output {
+ status: ExitStatus::from_raw(status),
+ stdout: out,
+ stderr: err,
+ };
}
};
let poem = match Poem::read(poetry, env) {
Ok(poem) => poem,
Err(e) => {
- eprintln!("dwvsh: {}", e.to_string().to_lowercase());
+ if uerr {
+ err.append(
+ &mut format!("dwvsh: {}", e.to_string().to_lowercase())
+ .as_bytes()
+ .to_vec(),
+ );
+ } else {
+ eprintln!("dwvsh: {}", e.to_string().to_lowercase());
+ }
continue;
}
};
- *out = match poem.recite(env) {
- Ok(out) => out,
+ status = match poem.recite(env) {
+ Ok(mut sout) => {
+ if uout {
+ out.append(&mut sout);
+ } else {
+ if !sout.is_empty() {
+ println!("{}", String::from_utf8_lossy(&sout));
+ }
+ }
+ 0
+ }
Err(e) => {
- eprintln!("dwvsh: {}", e.to_string().to_lowercase());
- continue;
+ if uerr {
+ err.append(
+ &mut format!("dwvsh: {}", e.to_string().to_lowercase())
+ .as_bytes()
+ .to_vec(),
+ );
+ } else {
+ eprintln!("dwvsh: {}", e.to_string().to_lowercase());
+ }
+ 1
}
};
}
- 0
+ Output {
+ status: ExitStatus::from_raw(status),
+ stdout: out,
+ stderr: err,
+ }
}